Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and host algorithm images on GitHub (base images) #20

Merged
merged 30 commits into from
Nov 20, 2023

Conversation

CodeLionX
Copy link
Member

@CodeLionX CodeLionX commented Nov 15, 2023

This PR moves our algorithm image build infrastructure from our internal Gitlab instance to GitHub Actions (#25).

Additions:

  • use GitHub actions to build and test PR algorithm images
  • use GitHub actions to publish algorithm images to GitHub packages once the PR is merged to main
  • adapt and publish base images in this PR, others will follow

Changes to internal build process:

  • We don't publish temporary images to the registry.
  • We add helpful labels to the images (based on OCI standard).
  • Each image is built and versioned independently. We use the version-key in the manifest of algorithms and a separate version.txt-file for our base images.

Some limitation:
Jobs always require the correct version of base images already available at the registry. This means if a PR introduces changes to, e.g., lof, the requested version of the ghcr.io/timeeval/pyod base image must be available from the registry (pull must succeed). This means that changes to images must be made in consecutive PRs:

  1. base images
  2. intermediate images
  3. algorithm images

I will use this order for the introduction of the CI changes as well.

@CodeLionX CodeLionX self-assigned this Nov 15, 2023
@CodeLionX CodeLionX marked this pull request as ready for review November 15, 2023 16:10
@CodeLionX CodeLionX changed the title Build and host algorithm images on GitHub Build and host algorithm images on GitHub (base images) Nov 20, 2023
@CodeLionX CodeLionX requested a review from wenig November 20, 2023 13:15
@CodeLionX CodeLionX merged commit 96af897 into main Nov 20, 2023
5 checks passed
@CodeLionX CodeLionX deleted the feat/build-images-ci branch November 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants